Add port of prepare_deploy_cfg.py #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next will add a cli command that runs it
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
============================================
+ Coverage 71.80% 72.16% +0.35%
- Complexity 691 705 +14
============================================
Files 46 47 +1
Lines 3721 3768 +47
Branches 657 664 +7
============================================
+ Hits 2672 2719 +47
Misses 815 815
Partials 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tests require it. Not sure whether it's actually used or not, so safe side for now
UJS no longer exists the njs_wrapper endpoint doesn't exist either, but not sure if that's used to pass the ee2 url
briehl
approved these changes
Oct 20, 2025
| shockUrl = getConfigUrl(props, "shock_url", endPoint, "shock-api"); | ||
| handleUrl = getConfigUrl(props, "handle_url", endPoint, "handle_service"); | ||
| srvWizUrl = getConfigUrl(props, "srv_wiz_url", endPoint, "service_wizard"); | ||
| // not sure if this is still used for the ee2 url or not |
There was a problem hiding this comment.
But, sure, leave it in for now. Do we need to do some kind of audit to find out?
There was a problem hiding this comment.
I don't think it's harmful to leave it for now. I'm not planning to do anything unless it becomes an issue
Comment on lines
+43
to
+44
| // for now. We might want to be more stringent about the input vs. silently accepting | ||
| // whatever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next will add a cli command that runs it